Add configuration option to override default text rendering#2470
Merged
EchoEllet merged 2 commits intosingerdmx:masterfrom Feb 16, 2025
Merged
Add configuration option to override default text rendering#2470EchoEllet merged 2 commits intosingerdmx:masterfrom
EchoEllet merged 2 commits intosingerdmx:masterfrom
Conversation
tjarvstrand
force-pushed
the
custom-textspan-rendering
branch
2 times, most recently
from
5bd8084 to
374c164
Compare
tjarvstrand
force-pushed
the
custom-textspan-rendering
branch
from
374c164 to
7cffb03
Compare
EchoEllet
requested changes
Feb 15, 2025
tjarvstrand
force-pushed
the
custom-textspan-rendering
branch
from
7a9fea2 to
c9b16e7
Compare
CatHood0
approved these changes
Feb 15, 2025
Collaborator
CatHood0
left a comment
CatHood0
left a comment
There was a problem hiding this comment.
LGTM. I didn't see any changes that would cause any new errors, just some things with formatting and the TextSpanBuilder.
Contributor
Author
|
I believe the formatting error may be due to the updated formatting rules in Dart 3.7? It's in
Was there something I should fix related to |
Collaborator
I'm not able to reproduce this formatting issue with Dart 3.7 or 3.6 locally, I have disabled the formatting check in CI for now. |
Contributor
Author
|
Thanks! |
CatHood0
pushed a commit
to CatHood0/flutter-quill
that referenced
this pull request
Feb 17, 2025
…x#2470) * Add configuration option to override default text rendering with a textSpanBuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow fine-grained customization of how text is rendered in the editor.
Description
This PR adds a configuration option that allows overriding how flutter_quill builds spans for text content. This will allow things like adding custom inline elements in the text without modifying the underlying document.
Related Issues
With this change, it will be a lot easier to build things like custom inline comments, mentions etc. on top of flutter_quill.
Related:
Type of Change