Skip to content

fix: correct selection while scrolling #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correct selection while scrolling #2665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/src/editor/editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,19 +984,21 @@ class RenderEditor extends RenderEditableContainerBox

if (position.offset < _extendSelectionOrigin!.baseOffset) {
_handleSelectionChange(
TextSelection(
DragTextSelection(
baseOffset: position.offset,
extentOffset: _extendSelectionOrigin!.extentOffset,
affinity: selection.affinity,
first: true,
),
cause,
);
} else if (position.offset > _extendSelectionOrigin!.extentOffset) {
_handleSelectionChange(
TextSelection(
DragTextSelection(
baseOffset: _extendSelectionOrigin!.baseOffset,
extentOffset: position.offset,
affinity: selection.affinity,
first: false,
),
cause,
);
Expand Down Expand Up @@ -1055,10 +1057,11 @@ class RenderEditor extends RenderEditableContainerBox
extentOffset = math.max(fromPosition.offset, toPosition.offset);
}

final newSelection = TextSelection(
final newSelection = DragTextSelection(
baseOffset: baseOffset,
extentOffset: extentOffset,
affinity: fromPosition.affinity,
first: toPosition == null || fromPosition.offset <= toPosition.offset,
);

// Call [onSelectionChanged] only when the selection actually changed.
Expand Down
8 changes: 5 additions & 3 deletions lib/src/editor/widgets/text/text_selection.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,22 +498,24 @@ class _TextSelectionHandleOverlayState

final isNormalized =
widget.selection.extentOffset >= widget.selection.baseOffset;
TextSelection newSelection;
DragTextSelection newSelection;
switch (widget.position) {
case _TextSelectionHandlePosition.start:
newSelection = TextSelection(
newSelection = DragTextSelection(
baseOffset:
isNormalized ? position.offset : widget.selection.baseOffset,
extentOffset:
isNormalized ? widget.selection.extentOffset : position.offset,
first: true,
);
break;
case _TextSelectionHandlePosition.end:
newSelection = TextSelection(
newSelection = DragTextSelection(
baseOffset:
isNormalized ? widget.selection.baseOffset : position.offset,
extentOffset:
isNormalized ? position.offset : widget.selection.extentOffset,
first: false,
);
break;
}
Expand Down