[WIP][c++/python/r] Pushdown SOMA object management to C++#4436
Draft
XanthosXanthopoulos wants to merge 20 commits intomainfrom
Draft
[WIP][c++/python/r] Pushdown SOMA object management to C++#4436XanthosXanthopoulos wants to merge 20 commits intomainfrom
XanthosXanthopoulos wants to merge 20 commits intomainfrom
Conversation
Tie metadata lifetime with C++ handle
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
+ Coverage 85.42% 85.55% +0.12%
==========================================
Files 136 136
Lines 21441 20978 -463
==========================================
- Hits 18317 17948 -369
+ Misses 3124 3030 -94
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Provide an alternative enum class to hide
tiledb_datatype_twhich cannot be forward declared.Changes:
Notes for Reviewer: