Skip to content

Conversation

@nkitsaini
Copy link

Describe your changes

Allow overriding connection while executing the sql magic. This is used in singlestore-labs/singlestoredb-python#47.

Issue number

Checklist before requesting a review

@kesmit13
Copy link
Collaborator

I'm not clear how this will have any effect in our notebook container since we are installing the official Jupysql package there.

@nkitsaini
Copy link
Author

nkitsaini commented Dec 10, 2024

@kesmit13 We will update the notebook image to install this fork instead of installing from pypi. We have done the same for modifications to dash library: Dockerfile changes

@kesmit13 kesmit13 merged commit 4373b96 into master Dec 10, 2024
@kesmit13 kesmit13 deleted the users/asaini/allow-connection-override branch December 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants