Skip to content

Fallback to connectionURL if internalConnectionURL is empty #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesmit13 merged 2 commits into from
Dec 11, 2025
Merged

Fallback to connectionURL if internalConnectionURL is empty #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d7279b
fallback to connectionURL if internalConnectionURL is empty
mohit-singlestore Dec 11, 2025
bb89764
review changes
mohit-singlestore Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions singlestoredb/ai/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def SingleStoreChatFactory(
manage_workspaces().organizations.current.inference_apis
)
info = inference_api_manager.get(model_name=model_name)
if not info.internal_connection_url:
info.internal_connection_url = info.connection_url
else:
info = InferenceAPIInfo(
service_id='',
Expand Down
2 changes: 2 additions & 0 deletions singlestoredb/ai/embeddings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ def SingleStoreEmbeddingsFactory(
manage_workspaces().organizations.current.inference_apis
)
info = inference_api_manager.get(model_name=model_name)
if not info.internal_connection_url:
info.internal_connection_url = info.connection_url
else:
info = InferenceAPIInfo(
service_id='',
Expand Down