-
Notifications
You must be signed in to change notification settings - Fork 22
feat(stage): add support for starter workspaces #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should I create separate PRs for the |
kesmit13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm a little confused by the changes here. It appears as though you are making the commands only work for starter workspaces and not for traditional ones. I'm saying this because of the change from get_workspace_group to get_starter_workspace. Is that the intent, or is get_starter_workspace intended to return either a starter workspace or a traditional one? If it returns either one, it shouldn't be named get_starter_workspace and the return type needs to include both StarterWorkspace and WorkspaceGroup.
We also probably need to create two SQL commands: one that keeps GROUP in the command and another than has it removed because we have already released the command with GROUP in it. I don't think we can just make GROUP optional in a single command because of abmiguities that would be in parsing.
|
My bad, the Regarding the removal of the |
|
I think it's fine to have duplicate commands for now. In fact, you can take what you have now and just copy the whole command and add a |
227be09 to
b5b7b39
Compare
b5b7b39 to
0368c84
Compare
kesmit13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the wrong string had been used in the Arguments sections of the commands for anything that has a multi-word name. The syntax in the Arguments and Remarks should use - rather than _. The - version is what shows up in the Fusion help system. I realize you were just using the form that was there before, but if you could change all of those in this PR, that would be great. After that, I think it's ready to go.
0368c84 to
25041ca
Compare
We have recently updated the Stage Management API to add support for starter workspaces. Following this change, we would like to update the
SingleStoreDB Python SDKto also accommodate starter workspaces in stage resources.This PR introduces a basic
StarterWorkspaceobject and modifies theFusion SQLstage syntax. As discussed in Kanit's proposal, theIN GROUPsyntax has been simplified to justIN. For example, the previous commandSHOW STAGE FILES IN GROUP '{{ wg_name }}'has been updated toSHOW STAGE FILES IN '{{ wg_name }}'.cc: @ricardoasmarques @kanitsharma