fix: Fix object has no attribute servers for udfs
#87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shut down a previously started server if present when starting new python udf server.
In above code if
register_functionsfails we will be in a state where we think we have a running server but we don't. This results in unvicorn throwing an errorhas no attribute 'servers'when we try shutdown this not running server.I have made two changes to fix this (any one would resolve our issue):
_running_serverafter the function has been registeredshutdownonly after verifying that previous server actually startedTest
Tested by running this notebook.
An easy way to make
register_functionsfail is to not select a database.