Need to modify the main wrapper script too !#690
Merged
vsoch merged 2 commits intosingularityhub:mainfrom Apr 12, 2025
Merged
Conversation
Member
|
No worries! Can you bump this one more to 0.1.32? Turns out 0.1.31 was already on pypi so your previous change hasn't been released yet. The silver lining here is we can do that easily now. |
muffato
force-pushed
the
singularity_path_in_wrapper
branch
from
28fb879 to
2028b0b
Compare
Contributor
Author
|
Ah right, I remember 0.1.31 was released and then reverted. Since it remains on Pypi, I thought we should document it somewhere. Take a look at how I put it back in the Changelog and introduced 0.1.32 |
vsoch
approved these changes
Apr 12, 2025
Member
vsoch
left a comment
vsoch
left a comment
There was a problem hiding this comment.
I think that looks perfect. Let's merge and deploy this one - for realsies this time 😉
Thanks for both the feature and the fix!
Contributor
Author
|
Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry @vsoch but in #689 I forgot to update the most important of all scripts !