Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
==========================================
- Coverage 96.05% 95.82% -0.24%
==========================================
Files 40 39 -1
Lines 1926 1891 -35
==========================================
- Hits 1850 1812 -38
- Misses 76 79 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fatso83
approved these changes
Mar 18, 2025
Contributor
fatso83
left a comment
There was a problem hiding this comment.
seems legit.
All cases I could find just used the default Promise implementation anyway, when using this function.
a1cf658 to
c9d66cd
Compare
Everyone should be using native promises by now, or should know how to stub natives
c9d66cd to
d4e77e0
Compare
Member
Author
|
This has been published to the npm registry as part of |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everyone should be using native promises by now, or should know how to stub natives
How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpasses