Allow compiling LaTeX with lualatex#282
Merged
MasloMaslane merged 1 commit intosio2project:mainfrom Jan 30, 2025
Merged
Conversation
MasloMaslane
requested changes
Jan 29, 2025
Member
MasloMaslane
left a comment
MasloMaslane
left a comment
There was a problem hiding this comment.
Could you add some tests? For example to verify if --latex-compiler overrides config
This is necessary to use some TeX features, such as TikZ's graph drawing library. As there isn't a reasonable way of detecting the necessity of using lualatex, the --latex-compiler option is now also exposed through config.yml, to make it possible to export the package if the statement only compiles with the right latex compiler.
Contributor
Author
|
Thanks for pushing me to add tests, turns out I slightly broke the thing in a small last-minute refactor. I added what I'd consider to be a reasonable set of tests – let me know if you see any other cases we should be testing. When I'm running the tests locally, I'm getting some failures around the |
MasloMaslane
approved these changes
Jan 29, 2025
Member
MasloMaslane
left a comment
MasloMaslane
left a comment
There was a problem hiding this comment.
I’ll merge after the tests pass. Don’t worry about failing tests in run command, they sometimes fail and i didn’t have time to fix them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to use some TeX features, such as TikZ's graph drawing library.
As there isn't a reasonable way of detecting the necessity of using lualatex, the --latex-compiler option is now also exposed through config.yml, to make it possible to export the package if the statement only compiles with the right latex compiler.