Merged
Conversation
froggy1014
requested review from
KimHunJin,
ProdMoon,
azure-553,
danmin20,
frontman-git,
hy57in,
jiji-hoon96,
joel-jo-querypie,
saseungmin,
sudosubin and
synuns
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ProdMoon
approved these changes
Mar 14, 2025
| async function processConfigData(configRow) { | ||
| try { | ||
| if (!configRow || configRow.length === 0) { | ||
| console.warn('Config sheet is empty'); |
Contributor
There was a problem hiding this comment.
magic number들이 enum화 되면 좋을 것 같긴 한데, 너무 오버인 것 같기도 하구요... 엔터프라이즈 프로덕션 코드가 아니기 때문에 지금도 충분히 좋다고 생각합니다!
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Promise.all()을 활용한 병렬 요청으로 빌드 시간 감소 ( 4.911s -> 1.581s )
활동 후기 수집 데이터 반영 자동화