Use the default schedulre when starting new tasks#1536
Merged
sipsorcery merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
…arved on the current conext scheduler. Resolves #1535.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #1535 where SIP channels behave differently when started from async contexts, specifically preventing SIP messages (OPTIONS, INVITE) from being received. The fix explicitly specifies TaskScheduler.Default when starting long-running tasks to avoid them being starved on custom task schedulers that may be active in async contexts.
Changes:
- Updated all
Task.Factory.StartNewcalls withTaskCreationOptions.LongRunningto explicitly useTaskScheduler.DefaultandCancellationToken.None - Applied consistently across SIPTransport and all SIP channel types (UDP, TCP, WebSocket)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SIPSorcery/core/SIP/SIPTransport.cs | Updated ProcessReceiveQueue task creation to use TaskScheduler.Default |
| src/SIPSorcery/core/SIP/Channels/SIPUDPChannel.cs | Updated ExpireFailedSends task creation to use TaskScheduler.Default |
| src/SIPSorcery/core/SIP/Channels/SIPTCPChannel.cs | Updated AcceptConnections and PruneConnections task creation to use TaskScheduler.Default |
| src/SIPSorcery/core/SIP/Channels/SIPClientWebSocketChannel.cs | Updated MonitorReceiveTasks task creation to use TaskScheduler.Default |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid long running tasks getting starved on the current conext scheduler. Resolves #1535.