forked from WordPress/wordpress-develop
-
Notifications
You must be signed in to change notification settings - Fork 0
Add script_data_{$handle} filter for classic scripts #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
12
commits into
trunk
Choose a base branch
from
copilot/add-script-data-filter
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
661399e
Initial plan
Copilot 2c0960c
Add script_data_{$handle} filter for classic scripts
Copilot f4afe13
Fix test docblocks - remove TBD ticket annotations
Copilot d3cd233
Implement script_data_{$handle} filter correctly - outputs JSON scrip…
Copilot 4e490ee
Optimize print_script_data method - extract charset check outside loo…
Copilot 14e4ff9
Remove redundant is_array check and improve test naming
Copilot 16c9b3f
Refactor: Integrate script_data filter directly into do_item() method
Copilot 3edd50e
Add comment explaining wp_print_inline_script_tag return parameter
Copilot 0fbee29
Address code review feedback
Copilot d89d333
Add JSON_INVALID_UTF8_SUBSTITUTE flag for better UTF-8 handling
Copilot d9f018f
Revert "Add JSON_INVALID_UTF8_SUBSTITUTE flag for better UTF-8 handling"
Copilot cf669ad
Add JSON_INVALID_UTF8_SUBSTITUTE flag to avoid fallback overhead
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot This is not the idea. This system should be separate from
wp_localize_scriptwhich has its own issues.This
script_data_{$handle}filter should work just like it does for modules, outputting another JSON (not JavaScript) script tag if there's data to print.Familiarize yourself with how script modules do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right - I misunderstood the requirement. I've completely reimplemented this to match the script modules pattern:
print_script_data()method to WP_Scripts class (separate from wp_localize_script)<script type="application/json">tags with JSON dataThe implementation now works exactly like script modules - completely independent from wp_localize_script.
Fixed in commits: d3cd233, 4e490ee, 14e4ff9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored the implementation in commits d3cd233 and 4e490ee. The filter now works correctly:
wp_localize_script()- doesn't modify existing functionality<script type="application/json">tags (like script modules)print_script_data()method to WP_Scripts classwp_footer,login_footer, andadmin_print_footer_scriptsat priority 21script_data_{$handle}filterThe implementation now mirrors the script modules pattern exactly.