Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions lib/chrome/har.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { getLogger } from '@sitespeed.io/log';
import { harFromMessages } from 'chrome-har';
import { logging } from 'selenium-webdriver';
const log = getLogger('browsertime.chrome');
import { addBrowser } from '../support/har/index.js';
import { addBrowser, cleanSensitiveHeaders } from '../support/har/index.js';
const { Type } = logging;

export async function getHar(
Expand All @@ -15,7 +15,8 @@ export async function getHar(
mobileEmulation,
androidClient,
chrome,
aliasAndUrl
aliasAndUrl,
cleanHeaders
) {
log.debug('Getting performance logs from Chrome');

Expand All @@ -34,6 +35,17 @@ export async function getHar(

const har = harFromMessages(messages);

if (cleanHeaders === true) {
for (const entry of har.log.entries ?? []) {
for (const header of entry.request?.headers ?? []) {
header.value = cleanSensitiveHeaders(header.name, header.value);
}
for (const header of entry.response?.headers ?? []) {
header.value = cleanSensitiveHeaders(header.name, header.value);
}
}
}

if (includeResponseBodies === 'html' || includeResponseBodies === 'all') {
await cdpClient.setResponseBodies(har);
}
Expand Down
5 changes: 3 additions & 2 deletions lib/chrome/webdriver/chromium.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ export class Chromium {
const minLength = ${this.options.minLongTaskLength || 50};
const observer = new PerformanceObserver(list => {});
observer.observe({type: 'longtask', buffered: true});
const entries = observer.takeRecords();
const entries = observer.takeRecords();
const cleaned = [];
for (let event of entries) {
if (event.duration >= minLength) {
Expand Down Expand Up @@ -319,7 +319,8 @@ export class Chromium {
this.chrome.mobileEmulation,
this.android,
this.chrome,
this.aliasAndUrl
this.aliasAndUrl,
this.options.cleanSensitiveHeaders
)
);
}
Expand Down
114 changes: 41 additions & 73 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@sitespeed.io/log": "1.0.0",
"@sitespeed.io/throttle": "5.0.1",
"@sitespeed.io/tracium": "0.3.3",
"chrome-har": "1.0.1",
"chrome-har": "1.1.1",
"chrome-remote-interface": "0.33.3",
"execa": "9.6.0",
"fast-stats": "0.0.7",
Expand Down
Loading