Skip to content

Fix wrong error messages and include message in reject #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soulgalore wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix wrong error messages and include message in reject #4601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7fb0c0
Fix wrong error messages and include message in reject
soulgalore Mar 15, 2026
d2e87de
Merge branch 'main' into api-fix
soulgalore Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/api/send.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
} catch {
return reject({
message:
'Could parse result:' + Buffer.concat(data).toString('utf8')
'Could not parse result:' + Buffer.concat(data).toString('utf8')
});
}
}
Expand Down Expand Up @@ -85,14 +85,14 @@
} catch {
return reject({
message:
'Could parse result:' + Buffer.concat(data).toString('utf8')
'Could not parse result:' + Buffer.concat(data).toString('utf8')

Check failure on line 88 in lib/api/send.js

View workflow job for this annotation

GitHub Actions / build (20.x) 

Insert `⏎·················`
});
}
}
});
})
.on('error', () => {
return reject();
.on('error', error => {
return reject({ message: error.toString() });
});
});
}
Loading