Skip to content

Fix relative URL resolution in HTML page reports #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidarny wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix relative URL resolution in HTML page reports #4609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42ed39b
Fix relative URL resolution in HTML page reports
davidarny Mar 30, 2026
da87efd
Handle base href for run pages and useSameDir
davidarny Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/plugins/html/htmlBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,12 @@ export class HTMLBuilder {
)
: [];
let rootPath = this.storageManager.rootPathFromUrl(url, daurlAlias);
const summaryPagePath =
this.context.resultUrls.relativeSummaryPageUrl(url, daurlAlias) +
'index.html';
const baseHref = options.useSameDir
? undefined
: rootPath + summaryPagePath;
let data = {
daurl: url,
daurlAlias,
Expand All @@ -322,6 +328,7 @@ export class HTMLBuilder {
get,
markdown: markdown,
rootPath,
baseHref,
resultUrls: this.context.resultUrls,
assetsPath: assetsBaseURL || rootPath,
sitespeedioURL: options.html.homeurl,
Expand Down Expand Up @@ -370,6 +377,12 @@ export class HTMLBuilder {
run => !!get(pageInfo.data, [run.id, 'run'])
);
let rootPath = this.storageManager.rootPathFromUrl(url, daurlAlias);
const runPagePath =
this.context.resultUrls.relativeSummaryPageUrl(url, daurlAlias) +
`${iteration}.html`;
const baseHref = options.useSameDir
? undefined
: rootPath + runPagePath;
let data = {
daurl: url,
daurlAlias,
Expand All @@ -395,6 +408,7 @@ export class HTMLBuilder {
get,
markdown: markdown,
rootPath,
baseHref,
resultUrls: this.context.resultUrls,
assetsPath: assetsBaseURL || rootPath,
sitespeedioURL: options.html.homeurl,
Expand Down
2 changes: 2 additions & 0 deletions lib/plugins/html/templates/layout.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ html(lang='en')
head
meta(charset='utf-8')
meta(name='viewport', content='width=device-width, initial-scale=1')
if baseHref
base(href=baseHref)
title= pageTitle
meta(name='description', content=pageDescription)
meta(name='robots', content='noindex')
Expand Down
Loading