Fix scripting examples that call non-existent commands - #4791
Merged
Conversation
Several scripting examples used commands that don't exist or don't do what the text claims. switch.toTopFrame() and switch.toPreviousTab() aren't part of the API, and switch.toNewTab() opens a fresh tab rather than switching to a popup the page opened — so the iframe/popup recipes couldn't work as written; they now use the real frame/window APIs. The custom-metrics page claimed booleans are auto-converted to numbers, but values are stored as-is (the example itself converts manually). And the "test the same URL twice" tip called commands.navigate(url, alias), which ignores the alias and doesn't measure — it should be commands.measure.start. Co-authored-by: Claude Opus 4.8 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several scripting examples used commands that don't exist or don't do what
the text claims. switch.toTopFrame() and switch.toPreviousTab() aren't
part of the API, and switch.toNewTab() opens a fresh tab rather than
switching to a popup the page opened — so the iframe/popup recipes couldn't
work as written; they now use the real frame/window APIs. The custom-metrics
page claimed booleans are auto-converted to numbers, but values are stored
as-is (the example itself converts manually). And the "test the same URL
twice" tip called commands.navigate(url, alias), which ignores the alias
and doesn't measure — it should be commands.measure.start.
Co-authored-by: Claude Opus 4.8 (1M context) noreply@anthropic.com