Rename active workout to active workout session#405
Open
Conversation
ActiveWorkout is confusing, because it does not refer to a Workout(a workout plan), but a workout session (which can be without a Workout). This confusion can also be seen with the function setActiveWorkout, which does not change the whole ActiveWorkout, but only the .workout in the ActiveWorkout(Session)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The naming ActiveWorkout can be confusing, because it does not refer to a Workout(a workout plan), but more of a workout session (which can be without a Workout).
This confusion can also be seen with the function setActiveWorkout, which does not change the whole ActiveWorkout, but only the .workout in the ActiveWorkout(Session)