Open
Conversation
Current setup created React warnings due to setState in rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkoutIntervalInputhad some issues due to calling the parent when rendering.This was because the usage of the setWorkoutPart from the parent was not contained in useEffect.
This lead to warnings such as this:
Fixed by having the call in useEffect.
(That lead to a lot of rerenders, so add an if-check to just setTheWorkoutPart when it is actually changed)
Also removed the setWorkoutType from the actions, and just used the one from props
Not a React Expert, so it may be fixed in a better way. useMemo in the parent? IDK
Master (bug)
This pr (no warning :) )