Open
Conversation
Since they both are small, I think it is easiest to just combine them. Current solution makes it a bit hard to remember which one to click and such. Could ofc be solved another way (different icons). But I think this is an easier solution both for us and users. One could then delete one of the buttons, but I just kept both, since it is so symmetric :))
Owner
|
Hmm I kinda agree that it might be a bit difficult to remember/understand which button is which, since the icons are the same, but I think I would prefer doing something about that rather than forcing both sections to always be displayed together. I'll try to come up with a suggestion. We could probably add some text making it easier to understand that the right side is related to power and the left is related to workouts, but that might end up making the base look worse? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since they both are small, I think it is easiest to just combine them. Current solution makes it a bit hard to remember which one to click and such. Could ofc be solved another way (different icons). But I think this is an easier solution both for us and users.
One could then delete one of the buttons, but I just kept both, since it is so symmetric :))