Fix trainer color bug #485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Are you sure this was a bug and not just us trying to display it as red for the error? 😅 |
Owner
|
Also, I think you have to spell use |
Collaborator
Author
Someone should make semantic commits improved v2 version |
Collaborator
Author
Who knows. But since red is the actual color for the hr icon, it is not that obvious. |
morteako
force-pushed
the
fix-trainer-color-bug
branch
from
39fbb48 to
99c7290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes small bug regarding action bar color.
When disconnected, the power icon has red color, but it should have the power color, purple.
Also change string 'red.500' to the variable hrColor , which is
theme.colors.red[500], which should be the same