Merged
Conversation
…into Feat/issue-#43
…into Feat/issue-#43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 상세 내용
#️⃣ 이슈 번호
💬 리뷰 요구사항
백엔드랑 통신하는 부분은 문제 없고, 처음에 sockJS로 짠 코드를 다시 stomp로 바꾸고, props 관리가 너무 힘들어서 한 페이지에 다시 짠 코드를 조금씩 분리하고 있는 탓에 코드 로직 분리가 덜 되어있어요
코드 가독성 제외하곤 모바일 뷰도 적용했고, 일단 PR 올린 후에 뒤이어서 클린 코드 만들어 보겠습니다
⏰ 현재 버그
📷 스크린샷(선택)
모바일 뷰는 flex column으로 바꿔서 밑으로 내릴 수 있게 했어요!


🔗 참고 자료(선택)