Skip to content

Fix timeout bailout #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wildbiotiger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix timeout bailout #20

wildbiotiger wants to merge 1 commit into from

Conversation

@wildbiotiger
Copy link

@wildbiotiger wildbiotiger commented Feb 16, 2023

timeout was not correctly exiting the get_response loop, so, a RuntimeError has been added to the else check.

@wildbiotiger
Fix timeout bailout
1865939 
timeout was not correctly exiting the get_response loop, so, a RuntimeError has been added to the else check.
@wildbiotiger
Copy link
Author

wildbiotiger commented Feb 16, 2023

I realize the timeout is normally called via the logger.error, but for using it without the default logger instance, there needs to be an alternate bailout.

@saeedjohar saeedjohar requested a review from selengalp February 18, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@selengalp selengalp Awaiting requested review from selengalp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wildbiotiger