The plugin was not executed uninstall() when being uninstalled #16243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCOTC
commented
Oct 29, 2025
Comment on lines
-841
to
-843
| if (bazaarType === "plugins") { | ||
| uninstall(app, packageName, true); | ||
| } |
| data.removePlugins.concat(data.upsertPlugins).forEach((item) => { | ||
| uninstall(app, item); | ||
| data.removePlugins.forEach((item) => { | ||
| uninstall(app, item, true); |
Contributor
Author
There was a problem hiding this comment.
之前缺少 true 参数，导致没有执行插件的 uninstall() 方法
| import {getAllEditor} from "../layout/getAll"; | ||
|
|
||
| export const uninstall = (app: App, name: string, isUninstall = false) => { | ||
| export const uninstall = (app: App, name: string, isUninstall: boolean) => { |
Contributor
Author
There was a problem hiding this comment.
uninstall() 函数之前默认是不执行 uninstall 的，太迷惑人了，改成必选参数以避免以后使用时混淆用途
Comment on lines
-14
to
+27
| // rm command | ||
| try { | ||
| plugin.onunload(); | ||
| if (isUninstall) { | ||
| plugin.uninstall(); | ||
| window.siyuan.storage[Constants.LOCAL_PLUGIN_DOCKS][plugin.name] = {}; | ||
| setStorageVal(Constants.LOCAL_PLUGIN_DOCKS, window.siyuan.storage[Constants.LOCAL_PLUGIN_DOCKS]); | ||
| } | ||
| } catch (e) { | ||
| console.error(`plugin ${plugin.name} onunload error:`, e); | ||
| } | ||
| if (isUninstall) { | ||
| try { | ||
| plugin.uninstall(); | ||
| } catch (e) { | ||
| console.error(`plugin ${plugin.name} uninstall error:`, e); | ||
| } | ||
| window.siyuan.storage[Constants.LOCAL_PLUGIN_DOCKS][plugin.name] = {}; | ||
| setStorageVal(Constants.LOCAL_PLUGIN_DOCKS, window.siyuan.storage[Constants.LOCAL_PLUGIN_DOCKS]); | ||
| } |
8 tasks
3 tasks
Contributor
Author
|
这个 PR 合并之后还需要合并 #16244 |
Member
|
收到 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #16156
卸载插件目前由内核推送，调用 reloadPlugin() 函数之后没有执行插件的 uninstall() 方法。