Query MySQL only once for Uptime. #31
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running ps-top on an instance with general log enabled, I see the three (3) queries below being executed every second.
I trace this down to below:
In the grand scheme of things, running these 3 queries every second is not such a problem as the associated load on the database is probably negligible. On the other hand, this increases the number of queries needed every second by ps-top from 1 to 4, being 75% of the total number of queries run every second by ps-top. Moreover, these are not needed, as querying Uptime once should be enough to compute it client-side.
This PR removes the need for these 3 queries every second, querying Uptime only once, and then computing it client side.