This repository was archived by the owner on May 30, 2025. It is now read-only.
Bumps me.grishka.appkit:appkit to 1.2.15, fixes IllegalStateException on emoji/user picker#974
Open
Bumps me.grishka.appkit:appkit to 1.2.15, fixes IllegalStateException on emoji/user picker#974
Conversation
Author
|
A little update: I thought this would fix #920, but after deeper testing, there appears to exist another possible crash situation on here, one that is proving a lot more awful to reproduce, same steps, but the first one I could consistently hit by typing fast, this one not so easy. Unsure how I handle PRs, so, I'll leave this one here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IllegalStateException was removed on 1.2.15: grishka/appkit@9cacd1b, according to them, "No, it wasn't a good idea to throw that exception".
This fixes #920, which was, on personal experience, an awfully annoying bug to deal with it.
I have literally never done a PR on a project on my life, please let me know if I need to do something else.