perf: Optimize DELETE/DETACH DELETE performance#781
Open
MuhammadTahaNaveed wants to merge 1 commit intoskaiworldwide-oss:mainfrom
Open
perf: Optimize DELETE/DETACH DELETE performance#781MuhammadTahaNaveed wants to merge 1 commit intoskaiworldwide-oss:mainfrom
MuhammadTahaNaveed wants to merge 1 commit intoskaiworldwide-oss:mainfrom
Conversation
Collaborator
MuhammadTahaNaveed
commented
Oct 13, 2025
MuhammadTahaNaveed
commented
- Remove unnecessary sequential scans in DETACH DELETE.
- ~30x performance improvement from some rough tests.
- Added caches and indexes to find connected edges efficiently.
- Setting auto_gather_graphmeta to true automatically triggers regather_graphmeta to ensure correct metadata.
- When auto_gather_graphmeta is enabled, DETACH DELETE prunes the ag_edge inheritance tree and scans only edge labels connected to the target vertex. This optimization currently applies to vertices only, not paths. This further optimizes the DELETE operation.
- Remove unnecessary sequential scans in DETACH DELETE. - ~30x performance improvement from some rough tests. - Added caches and indexes to find connected edges efficiently. - Setting auto_gather_graphmeta to true automatically triggers regather_graphmeta to ensure correct metadata. - When auto_gather_graphmeta is enabled, DETACH DELETE prunes the ag_edge inheritance tree and scans only edge labels connected to the target vertex. This optimization currently applies to vertices only, not paths. This further optimizes the DELETE operation. Future Considerations: - Maybe we should remove the edge count column in ag_graphmeta which could slow down writes a bit and enable graphmeta permanently? - If no edge is connected, remove the join completely.
MuhammadTahaNaveed
force-pushed
the
delete-imp
branch
from
c3d29d0 to
b8c5836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.