Open
Conversation
curtismuntz
reviewed
Apr 14, 2025
Contributor
curtismuntz
left a comment
curtismuntz
left a comment
There was a problem hiding this comment.
I feel like this is the exact same script. Why not just throw arch / os logic inside the other script to help reduce constants / version drift between these?
At this stage of the project, supporting another OS may be feasible, but it's not a trivial thing in the long run. At the bare minimum, you should expand the CI to perform OSX builds so we know when PRs break either build.
Comment on lines
+12
to
+13
| if [ $(arch) != "arm64" ]; then | ||
| wget -O /tmp/bazelisk https://github.com/bazelbuild/bazelisk/releases/download/$BAZELISK_VERSION/bazelisk-darwin-arm64 |
Contributor
There was a problem hiding this comment.
The logic here seems reversed.
| if [ $(arch) != "arm64" ]; then | ||
| wget -O /tmp/bazelisk https://github.com/bazelbuild/bazelisk/releases/download/$BAZELISK_VERSION/bazelisk-darwin-arm64 | ||
| elif [ $(arch) != "x86_64" ]; then | ||
| wget -O /tmp/bazelisk https://github.com/bazelbuild/bazelisk/releases/download/$BAZELISK_VERSION/bazelisk-darwin-amd64 |
Contributor
There was a problem hiding this comment.
does osx come shipped with wget?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on OSX arm64, not amd64. Also renamed original tool that was Debian linux only