Fixed CSS code processing and minification#62
Open
nomelodic wants to merge 2 commits intoskeeks-semenov:masterfrom
Open
Fixed CSS code processing and minification#62nomelodic wants to merge 2 commits intoskeeks-semenov:masterfrom
nomelodic wants to merge 2 commits intoskeeks-semenov:masterfrom
Conversation
…on-empty BaseUrl. The issue was discussed here yiisoft/yii2#18414
The mrclay/minify extension did not handle relative paths correctly, in particular those with ../ and ./. It has written its own function that adjusts paths based on the initial location of the file and the final one. The natxet/cssmin extension does not correctly process already minified code, so it was replaced with the matthiasmullie/minify extension. Fix skeeks-semenov#43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mrclay/minify extension did not handle relative paths correctly, in particular those with
../and./. It has written its own function that adjusts paths based on the initial location of the file and the final one.An example of incorrect path handling
New path:
/var/www/site/web/assets/css-compressOld path:
/var/www/site/web/cssIn CSS codes, we have the path
../images/image1.png. After processing it should look like this../../images/image1.png, but instead mrclay/minify makes it like this.The natxet/cssmin extension does not correctly process already minified code, so it was replaced with the matthiasmullie/minify extension.
An example of incorrect code processing
Input has line
@media(max-width:767px){.table-responsive ..., and the output is@media max-width:767px){.table-responsive ....Fix #43