Skip to content

feat: add reservation-core logical-slot expiry recovery proof#118

Merged
skel84 merged 1 commit intomainfrom
feat/reservation-core-expiry-recovery
Mar 26, 2026
Merged

feat: add reservation-core logical-slot expiry recovery proof#118
skel84 merged 1 commit intomainfrom
feat/reservation-core-expiry-recovery

Conversation

@skel84
Copy link
Owner

@skel84 skel84 commented Mar 26, 2026

Summary

  • add logical-slot-driven overdue hold expiry to reservation-core using the existing bounded hold queue
  • rebuild hold expiry state from snapshots only for active holds and preserve explicit boundary expiry semantics
  • add recovery proofs for overdue holds after restart and torn-tail WAL truncation around expiry

Closes #113
Refs #109

Validation

  • cargo test -p reservation-core
  • cargo clippy -p reservation-core --all-targets --all-features -- -D warnings
  • cargo fmt --all --check
  • cargo test
  • scripts/check_repo.sh

Docs

  • no docs changes needed; this implements the existing reservation-engine-plan.md and reservation-semantics.md scope

CodeRabbit Triage

  • pending after push

@coderabbitai
Copy link

coderabbitai bot commented Mar 26, 2026

Warning

Rate limit exceeded

@skel84 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4b7ea385-4d13-43d2-86d5-4a53d2044708

📥 Commits

Reviewing files that changed from the base of the PR and between ddc271e and 0409fcb.

📒 Files selected for processing (3)
  • crates/reservation-core/src/recovery.rs
  • crates/reservation-core/src/snapshot.rs
  • crates/reservation-core/src/state_machine.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/reservation-core-expiry-recovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skel84 skel84 merged commit 3d59b0e into main Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M11-T04: Add logical-slot expiry and durability/recovery proof for reservation-core

1 participant