-
-
Notifications
You must be signed in to change notification settings - Fork 372
feature: Floating Panel
#4113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature: Floating Panel
#4113
Conversation
🦋 Changeset detectedLatest commit: 378cdfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… classes Co-authored-by: Hugos68 <[email protected]>
…ntions Co-authored-by: Hugos68 <[email protected]>
…om positioner Co-authored-by: Hugos68 <[email protected]>
Co-authored-by: Hugos68 <[email protected]>
|
@copilot |
Co-authored-by: Hugos68 <[email protected]>
Fixed both issues in commit aaa4163:
All checks now pass:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Couple of things:
|
|
@copilot The resizer trigger is supposed to go outside of the body, not inside, could you update all examples, anatomy docs, playgrounds where FloatingPanel is used and move the ResizeTrigger components outside the FloatingPanel.Body component? |
Completed in commit d6f72b3. Moved ResizeTrigger outside of FloatingPanel.Body (now correctly placed inside FloatingPanel.Content) across all 16 example files (8 React + 8 Svelte). Also added helpful descriptive text to all examples explaining their functionality. |
Linked Issue
Closes #4111
Description
Successfully implemented the Floating Panel component utilizing Zag.js for both React and Svelte frameworks. The component provides draggable, resizable panels with minimize/maximize/restore controls.
Implementation
skeleton-common
classesFloatingPanelwith 11 anatomy partsskeleton-svelte
skeleton-react
Documentation (floating-panel.mdx)
@zag-js/floating-panel]:resizableset to false still allows resizing chakra-ui/zag#2860)Features
Quality Assurance
Dependencies
Checklist
Please read and apply all contribution requirements.
docs/,feature/,task/,bugfix/mainbranchpnpm checkin the root of the monorepopnpm formatin the root of the monorepopnpm lintin the root of the monorepopnpm testin the root of the monorepo/packageprojects, please supply a ChangesetChangesets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changesetand follow the promptsOriginal prompt
Floating Panelcomponent #4111💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.