-
-
Notifications
You must be signed in to change notification settings - Fork 372
perf: monorepo improvements #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@copilot Can you create a PR against this branch that removes all uses of |
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Hugos68 <[email protected]>
|
@copilot This PR moves from testing library to vitest browser mode, please update every test to use vitest browser mode setup: // Test loading state // Test for data to load (expect.element auto-retries) |
…ng (#4137) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Hugos68 <[email protected]>
|
@copilot Your last PR migrated to vites tbrowser mode test setup which is great, but the render function is async, please make all tests that utilize |
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Hugo Korte <[email protected]>
|
@copilot The svelte API actually doesn't need async, so remove any unneccesary ascyn or await keywordsa in the svelte package |
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Hugos68 <[email protected]>
Improves monorepo performance: