Skip to content

Conversation

@Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Nov 21, 2025

Improves monorepo performance:

  • Use rolldown-vite
  • ...

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: 9f69f47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Hugos68 Hugos68 marked this pull request as draft November 21, 2025 12:23
@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
themes.skeleton.dev Building Building Preview Nov 21, 2025 3:34pm
www.skeleton.dev Error Error Nov 21, 2025 3:34pm

@Hugos68
Copy link
Contributor Author

Hugos68 commented Nov 21, 2025

@copilot Can you create a PR against this branch that removes all uses of @/ paths alias inside all packages/* projects, this PR removes the aliases as prep for some upcoming stuff. Just grep @/ inside import paths in pacakges/* and replace them with the correct relative path instead.

Copy link
Contributor

Copilot AI commented Nov 21, 2025

@Hugos68 I've opened a new pull request, #4136, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Hugos68 <[email protected]>
@Hugos68
Copy link
Contributor Author

Hugos68 commented Nov 21, 2025

@copilot This PR moves from testing library to vitest browser mode, please update every test to use vitest browser mode setup:
test('UserProfile handles loading and data states', async () => {
const { getByText } = render()

// Test loading state
await expect.element(getByText('Loading...')).toBeInTheDocument()

// Test for data to load (expect.element auto-retries)
await expect.element(getByText('User: John')).toBeInTheDocument()
})

Copy link
Contributor

Copilot AI commented Nov 21, 2025

@Hugos68 I've opened a new pull request, #4137, to work on those changes. Once the pull request is ready, I'll request review from you.

…ng (#4137)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Hugos68 <[email protected]>
@Hugos68
Copy link
Contributor Author

Hugos68 commented Nov 21, 2025

@copilot Your last PR migrated to vites tbrowser mode test setup which is great, but the render function is async, please make all tests that utilize render async and await the render call.

Copy link
Contributor

Copilot AI commented Nov 21, 2025

@Hugos68 I've opened a new pull request, #4138, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Hugo Korte <[email protected]>
@Hugos68
Copy link
Contributor Author

Hugos68 commented Nov 21, 2025

@copilot The svelte API actually doesn't need async, so remove any unneccesary ascyn or await keywordsa in the svelte package

Copy link
Contributor

Copilot AI commented Nov 21, 2025

@Hugos68 I've opened a new pull request, #4139, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Hugos68 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants