Revert "chore: Revert updates to honor maintenance mode"#347
Revert "chore: Revert updates to honor maintenance mode"#347FidelusAleksander merged 1 commit intomainfrom
Conversation
This reverts commit 1c41ede.
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous revert (PR #338), effectively re-applying updates that modernize the "Hello GitHub Actions" exercise infrastructure. The changes transition from a legacy step-tracking system to the newer exercise-toolkit framework.
Changes:
- Replaces old workflow files with new exercise-toolkit-based workflows that provide better learner feedback
- Updates README to use "exercise" terminology instead of "course" and modernizes the onboarding flow
- Replaces step documentation files with updated content featuring theory sections, improved formatting, and clearer instructions
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated terminology from "course" to "exercise", modernized instructions, updated copyright to 2025 |
| .github/workflows/0-start-exercise.yml | New workflow to initialize the exercise and create tracking issue |
| .github/workflows/1-step.yml | New Step 1 workflow with comprehensive validation and feedback using exercise-toolkit |
| .github/workflows/2-step.yml | New Step 2 workflow for job validation |
| .github/workflows/3-step.yml | New Step 3 workflow for step validation with actionlint integration |
| .github/workflows/4-step.yml | New Step 4 workflow triggered on PR open to advance to final step |
| .github/workflows/5-step.yml | New Step 5 workflow triggered on PR close to finish the exercise |
| .github/workflows/0-welcome.yml | Removed old welcome workflow |
| .github/workflows/1-create-a-workflow.yml | Removed old step 1 workflow |
| .github/workflows/2-add-a-job.yml | Removed old step 2 workflow |
| .github/workflows/3-add-actions.yml | Removed old step 3 workflow |
| .github/workflows/4-merge-your-pull-request.yml | Removed old step 4 workflow |
| .github/workflows/5-trigger.yml | Removed old step 5 workflow |
| .github/steps/1-step.md | New step 1 instructions with theory section and improved formatting |
| .github/steps/2-step.md | New step 2 instructions about jobs |
| .github/steps/3-step.md | New step 3 instructions about steps |
| .github/steps/4-step.md | New step 4 instructions about triggering workflows |
| .github/steps/5-step.md | New step 5 instructions about merging |
| .github/steps/x-review.md | New completion message |
| .github/steps/0-welcome.md | Removed old welcome step |
| .github/steps/1-create-a-workflow.md | Removed old step 1 instructions |
| .github/steps/2-add-a-job.md | Removed old step 2 instructions |
| .github/steps/3-add-actions.md | Removed old step 3 instructions |
| .github/steps/4-merge-your-pull-request.md | Removed old step 4 instructions |
| .github/steps/5-trigger.md | Removed old step 5 instructions |
| .github/steps/X-finish.md | Removed old finish step |
| .github/steps/-step.txt | Removed old step tracking file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Because you set the workflow to run on the `pull_request` event, it will automatically trigger when a pull request is opened. | ||
|
|
||
| > [!TIP] | ||
| > Workflow associated to pull request can also be seen on the pull request log near the merge button. You can even [create a rule](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets#require-status-checks-to-pass-before-merging) that prevents merging if the workflow fails! |
There was a problem hiding this comment.
Incorrect preposition usage. The sentence should use "associated with" instead of "associated to". The corrected text should read "Workflows associated with pull requests can also be seen..." or "A workflow associated with a pull request can also be seen...".
| > Workflow associated to pull request can also be seen on the pull request log near the merge button. You can even [create a rule](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets#require-status-checks-to-pass-before-merging) that prevents merging if the workflow fails! | |
| > Workflows associated with a pull request can also be seen in the pull request log near the merge button. You can even [create a rule](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets#require-status-checks-to-pass-before-merging) that prevents merging if the workflow fails! |
|
|
||
| - name: Disable current workflow and enable next one | ||
| run: | | ||
| gh workflow disable "${{github.workflow}}" |
There was a problem hiding this comment.
The expression syntax should be consistent with spacing. Throughout the workflow files, most expressions use spaces inside the delimiters (e.g., ${{ secrets.GITHUB_TOKEN }}), but this line uses ${{github.workflow}} without spaces. For consistency with the rest of the codebase, this should be ${{ github.workflow }} with spaces.
| gh workflow disable "${{github.workflow}}" | |
| gh workflow disable "${{ github.workflow }}" |
|
|
||
| - name: Disable current workflow and enable next one | ||
| run: | | ||
| gh workflow disable "${{github.workflow}}" |
There was a problem hiding this comment.
The expression syntax should be consistent with spacing. Throughout the workflow files, most expressions use spaces inside the delimiters (e.g., ${{ secrets.GITHUB_TOKEN }}), but this line uses ${{github.workflow}} without spaces. For consistency with the rest of the codebase, this should be ${{ github.workflow }} with spaces.
| gh workflow disable "${{github.workflow}}" | |
| gh workflow disable "${{ github.workflow }}" |
|
|
||
| - name: Disable current workflow and enable next one | ||
| run: | | ||
| gh workflow disable "${{github.workflow}}" |
There was a problem hiding this comment.
The expression syntax should be consistent with spacing. Throughout the workflow files, most expressions use spaces inside the delimiters (e.g., ${{ secrets.GITHUB_TOKEN }}), but this line uses ${{github.workflow}} without spaces. For consistency with the rest of the codebase, this should be ${{ github.workflow }} with spaces.
| gh workflow disable "${{github.workflow}}" | |
| gh workflow disable "${{ github.workflow }}" |
|
|
||
| - name: Disable current workflow and enable next one | ||
| run: | | ||
| gh workflow disable "${{github.workflow}}" |
There was a problem hiding this comment.
The expression syntax should be consistent with spacing. Throughout the workflow files, most expressions use spaces inside the delimiters (e.g., ${{ secrets.GITHUB_TOKEN }}), but this line uses ${{github.workflow}} without spaces. For consistency with the rest of the codebase, this should be ${{ github.workflow }} with spaces.
| gh workflow disable "${{github.workflow}}" | |
| gh workflow disable "${{ github.workflow }}" |
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Disable current workflow | ||
| run: gh workflow disable "${{github.workflow}}" |
There was a problem hiding this comment.
The expression syntax should be consistent with spacing. Throughout the workflow files, most expressions use spaces inside the delimiters (e.g., ${{ secrets.GITHUB_TOKEN }}), but this line uses ${{github.workflow}} without spaces. For consistency with the rest of the codebase, this should be ${{ github.workflow }} with spaces.
| run: gh workflow disable "${{github.workflow}}" | |
| run: gh workflow disable "${{ github.workflow }}" |
|
|
||
| Jobs help you organize your workflow into logical units, such as building, testing, or deploying your code. | ||
|
|
||
| > [!Tip] |
There was a problem hiding this comment.
The GitHub alert syntax should use uppercase for consistency. This uses [!Tip] but the standard GitHub alert syntax and other files in this repository use [!TIP] in all caps. This should be changed to > [!TIP] to match the convention used in 3-step.md, 4-step.md, and 5-step.md.
| Every new pull request regardless of branch will now automatically trigger the workflow you created. | ||
|
|
||
| > [!TIP] | ||
| > Some event triggers, like [workflow_dispatch](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch) and [schedule](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule) will only work if the workflow file exists in default branch. |
There was a problem hiding this comment.
Missing article before "default branch". The sentence should read "will only work if the workflow file exists in the default branch" with the article "the" before "default branch".
| > Some event triggers, like [workflow_dispatch](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch) and [schedule](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule) will only work if the workflow file exists in default branch. | |
| > Some event triggers, like [workflow_dispatch](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch) and [schedule](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule) will only work if the workflow file exists in the default branch. |
1 participant
Reverts #338