[Bug] Step 1 fails with old Azure DevOps domain (*.visualstudio.com)

[ShawnMcGough]

Summary

The Terrform plugin fails during repo creation. My best guess is due to the 'old' Azure DevOps domain of *.visualstudio.com.

azuredevops_git_repository.repo: Creating...
╷
│ Error: Plugin did not respond
│ 
│   with azuredevops_git_repository.repo,
│   on project.tf line 10, in resource "azuredevops_git_repository" "repo":
│   10: resource "azuredevops_git_repository" "repo" {
│ 
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ApplyResourceChange call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│ 
│   with azuredevops_workitem.update_readme,
│   on workitems.tf line 3, in resource "azuredevops_workitem" "update_readme":
│    3: resource "azuredevops_workitem" "update_readme" {
│ 
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ApplyResourceChange call. The plugin logs may contain more details.
╵

Stack trace from the terraform-provider-azuredevops_v1.10.0 plugin:

panic: runtime error: index out of range [3] with length 3

goroutine 46 [running]:
github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/service/workitemtracking.resourceWorkItemCreate(0xc000223080, {0xedd880, 0xc00075c1e0})
        github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/service/workitemtracking/resource_workitem.go:140 +0x316
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0x12af820?, {0x12af820?, 0xc0000e99b0?}, 0xd?, {0xedd880?, 0xc00075c1e0?})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:826 +0x15f
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0xc0003f6500, {0x12af820, 0xc0000e99b0}, 0xc0002185b0, 0xc000222e80, {0xedd880, 0xc00075c1e0})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:969 +0xa8b
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0xc0003726d8, {0x12af820?, 0xc0000e97d0?}, 0xc00025b180)
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/grpc_provider.go:1188 +0xd1a
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ApplyResourceChange(0xc0001efe00, {0x12af820?, 0xc0002d36e0?}, 0xc0000fd030)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/tf5server/server.go:866 +0x3b9
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0x10f5b40, 0xc0001efe00}, {0x12af820, 0xc0002d36e0}, 0xc000222600, 0x0)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:611 +0x1a6
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0001f6200, {0x12af820, 0xc0002d3680}, 0xc0005793e0, 0xc0003fd8c0, 0x19e0818, 0x0)
        google.golang.org/grpc@v1.69.4/server.go:1392 +0xfbe
google.golang.org/grpc.(*Server).handleStream(0xc0001f6200, {0x12b0158, 0xc000480000}, 0xc0005793e0)
        google.golang.org/grpc@v1.69.4/server.go:1802 +0xb88
google.golang.org/grpc.(*Server).serveStreams.func2.1()
        google.golang.org/grpc@v1.69.4/server.go:1030 +0x7f
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 22
        google.golang.org/grpc@v1.69.4/server.go:1041 +0x11d

Error: The terraform-provider-azuredevops_v1.10.0 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

How to reproduce

1. Attempt Step 1 with old style *.visualstudio.com domain

Workaround

Update Organization settings to "Use the new URL"
https://*.visualstudio.com/_settings/organizationOverview

[FidelusAleksander]

Hey @ShawnMcGough

Any particular reason why you would use this?

https://*.visualstudio.com/

The exercise suggests you to use dev.azure.com URL and looking at the error it looks like even the terraform provider doesn't support the URL you provided

[ShawnMcGough]

I wanted to test the old Azure DevOps url and see if migration would work as some customers are still using the old https://*.visualstudio.com/ url.

At first it appeared that just the setup of the dummy project fails, but the migrator fails as well. It is worth documenting somewhere that the old url must first be upgraded before migration, but that likely belongs with the downstream tool. Feel free to close bug as the ado2gh extension doesn't support the old url.

[FidelusAleksander]

@ShawnMcGough Thanks for the context!

I'd love to support it as long as the underlying tools support it which as you say may not be the case...