Skip to content

feat: migrate exercise to issue-based flow#85

Closed
chriswblake wants to merge 14 commits intoskills:mainfrom
skills-dev:main
Closed

feat: migrate exercise to issue-based flow#85
chriswblake wants to merge 14 commits intoskills:mainfrom
skills-dev:main

Conversation

@chriswblake
Copy link
Member

This pull request includes extensive updates to improve the structure, clarity, and functionality of a GitHub course on reviewing pull requests. The changes involve rewriting step instructions for better user experience, introducing new workflows, and removing deprecated files. Below is a summary of the most important changes:

Improvements to step instructions:

Workflow updates:

Removal of deprecated files:

  • .github/steps/-step.txt, .github/steps/0-welcome.md, .github/steps/5-apply-changes.md, .github/steps/6-merge-your-pull-request.md, .github/steps/X-finish.md: Removed outdated files and consolidated content into revised steps. [1] [2] [3] [4] [5]
  • .github/workflows/0-welcome.yml: Removed the old workflow in favor of the newly introduced 0-start-exercise.yml.

These changes aim to streamline the learning experience, improve clarity, and automate repetitive tasks for learners.

@chriswblake chriswblake self-assigned this May 30, 2025
README.md Outdated
Simply copy the exercise to your account, then give your favorite Octocat (Mona) **about 20 seconds** to prepare the first lesson, then **refresh the page**.

---
[![](https://img.shields.io/badge/Copy%20Exercise-%E2%86%92-1f883d?style=for-the-badge&logo=github&labelColor=197935)](https://github.com/new?template_owner=chriswblake&template_name=review-pull-requests&owner=%40me&name=skills-review-pull-requests&description=Exercise%3A+Review+pull+requests&visibility=public)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update the owner in the url before merging.

@skills skills deleted a comment from camilasantos1989 Jun 11, 2025
@NicoleDev021
Copy link
Contributor

Hello, will these changes be completed soon? I would like to work on the exercise using the new workflow via actions.

@chriswblake
Copy link
Member Author

@NicoleDev021, unfortunately there are some internal business decisions preventing us from officially publishing these updates right now. It will probably be a few weeks before that happens.

For now, you are welcome to take the exercise from the source version (skills-dev). We consider this update done so nothing should change before launch.

@NicoleDev021
Copy link
Contributor

ok, thank you very much. I'm trying to get more into contributing to open source, and your repos have been an easy way in! You guys are very responsive :)

@NicoleDev021
Copy link
Contributor

@chriswblake Hello, I noticed some spelling errors while I was going through it and took the opportunity to make a pull request on the dev branch :)
https://github.com/skills-dev/review-pull-requests/pull/1

Copy link

@abdellamahmoud98 abdellamahmoud98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep up the good work

@skills skills deleted a comment from srinivasulu0514 Jul 2, 2025
@Gianpierr
Copy link

looks really good!

@chriswblake
Copy link
Member Author

Migration is on pause until further notice. You are welcome to take the skills-dev version at:
https://github.com/skills-dev/review-pull-requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants