Skip to content

[WIP] fix bug in examples #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaelVaroquaux merged 10 commits into from
May 15, 2020
Merged

[WIP] fix bug in examples #119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
959e9cb
WIP fix examples
TwsThomas May 14, 2020
bb8484c
test CI
TwsThomas May 14, 2020
f6dccbf
test
TwsThomas May 14, 2020
3a930d8
replace fetch_employees salary
TwsThomas May 14, 2020
520dc8c
minor import refactor
TwsThomas May 14, 2020
b387c3c
refactor code with df name from openML
TwsThomas May 14, 2020
b2aea04
refactor target in fetching.py
TwsThomas May 14, 2020
041060f
minor
TwsThomas May 14, 2020
b3c8d25
update change.rst
TwsThomas May 15, 2020
e6ea1ed
Update CHANGES.rst indent
TwsThomas May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Release 0.0.7
=============
* **datasets.fetch_employee_salaries**: change the origin of download for employee_salaries.
Copy link
Member

@GaelVaroquaux GaelVaroquaux May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention that this changed the function signature: the function now return a Bunch with a dataframe under the field "data", and not the path to the csv file. Also, the field "description" has been renamed to "DESCR".

Mentioning this is important, because these changes can break user code, and they need to quickly identify them from the changelog.

- The function now return a bunch with a dataframe under the field "data",
and not the path to the csv file.
- The field "description" has been renamed to "DESCR".


Release 0.0.6
=============
Expand Down
1 change: 0 additions & 1 deletion examples/02_fit_predict_plot_employee_salaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

################################################################################
# Now, let's carry out some basic preprocessing:
df['Current Annual Salary'] = employee_salaries['target']
df['Date First Hired'] = pd.to_datetime(df['date_first_hired'])
df['Year First Hired'] = df['Date First Hired'].apply(lambda x: x.year)

Expand Down