Skip to content

Conversation

@rcap107
Copy link
Member

@rcap107 rcap107 commented Jan 20, 2026

related to #1821

@rcap107
Copy link
Member Author

rcap107 commented Jan 20, 2026

It seems like the tests are failing because pyparsing is now version 3.3.1, while the lock file in main is still using 3.2.5. According to the release notes (https://github.com/pyparsing/pyparsing/blob/master/CHANGES):

In the pyparsing release 3.3.0, use of many of the pre-PEP8 methods (such as
ParserElement.parseString) will start to raise DeprecationWarnings. I plan to
completely drop the pre-PEP8 methods in pyparsing 4.0, though we won't see that release
until some time later in 2026. So there is plenty of time to convert existing parsers to
the new function names before the legacy functions are completely removed.

I'm pinning the pyparsing version for the time being

@rcap107
Copy link
Member Author

rcap107 commented Jan 20, 2026

I'm also updating the ci config to remove the deploy step as per https://circleci.com/docs/guides/orchestrate/migrate-from-deploy-to-run/

@rcap107 rcap107 marked this pull request as ready for review January 20, 2026 10:09
@rcap107 rcap107 changed the title WIP - trying to debug ci failing with latest pixi version FIX - CI is failing with latest pixi lock version Jan 20, 2026
- run:
command: |
if [[ "${CIRCLE_BRANCH}" =~ ^main$|^[0-9]+\.[0-9]+\.X$ ]]; then
if [[ "${CIRCLE_BRANCH}" =~ ^main$|^[0-9]+\.[0-9]+\.X$|^fix-pixi$ ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still want to keep this fix-pixi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops no, I forgot to remove this

matplotlib = "==3.4.3"
pydot = "*"
requests = "==2.27.1"
pyparsing = "<3.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put a small comment above to explain why

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@rcap107 rcap107 merged commit 35f4341 into skrub-data:main Jan 20, 2026
50 of 71 checks passed
@glemaitre
Copy link
Member

Thanks @rcap107 for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants