-
Notifications
You must be signed in to change notification settings - Fork 202
FIX - CI is failing with latest pixi lock version #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems like the tests are failing because pyparsing is now version 3.3.1, while the lock file in main is still using 3.2.5. According to the release notes (https://github.com/pyparsing/pyparsing/blob/master/CHANGES):
I'm pinning the pyparsing version for the time being |
|
I'm also updating the ci config to remove the |
.circleci/config.yml
Outdated
| - run: | ||
| command: | | ||
| if [[ "${CIRCLE_BRANCH}" =~ ^main$|^[0-9]+\.[0-9]+\.X$ ]]; then | ||
| if [[ "${CIRCLE_BRANCH}" =~ ^main$|^[0-9]+\.[0-9]+\.X$|^fix-pixi$ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you still want to keep this fix-pixi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops no, I forgot to remove this
| matplotlib = "==3.4.3" | ||
| pydot = "*" | ||
| requests = "==2.27.1" | ||
| pyparsing = "<3.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put a small comment above to explain why
glemaitre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
|
Thanks @rcap107 for the fix :) |
related to #1821