Conversation
fkiraly
added
the
maintenance
fkiraly
requested review from
benHeid,
fnhirwa,
jdb78 and
yarnabrina
as code owners
fkiraly
changed the title
models.base modulemodels.base module - part 1
fkiraly
added a commit
that referenced
this pull request
Feb 22, 2025
Part 2 of #1773, separate in order to ensure that files are properly tracked as renamed.
fkiraly
added a commit
that referenced
this pull request
Feb 22, 2025
Part 2 of #1773, separate in order to ensure that files are properly tracked as renamed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the model base classes into the
modeles.basemodule, which is a folder module with private submodules.This is a pure refactor, preparing for a
basemodule with more files - for instance, towards #1771.Part 1 of 2, part 2 in #1776, separate in order to ensure that files are properly tracked as renamed.