Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
=======================================
Coverage ? 86.63%
=======================================
Files ? 165
Lines ? 9740
Branches ? 0
=======================================
Hits ? 8438
Misses ? 1302
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@benHeid @fkiraly @fnhirwa @jdb78 @phoeenniixx @PranavBhatP @yarnabrina Hi all, I’ve addressed the feedback and updated the PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1703
What does this implement/fix? Explain your changes.
The
DATA_PATHinpytorch_forecasting/data/examples.pywas set toPath(__file__).parent, which points to the package installation directory (e.g., site-packages). This caused issues when the library was installed via pip, as:Fix:
DATA_PATHto use~/.pytorch-forecasting/data/as the default locationPTF_DATA_DIRenvironment variable for user customizationWhat should a reviewer concentrate their feedback on?
~/.pytorch-forecasting/data/an appropriate default location?Did you add any tests for the change?
No tests added yet. The issue is difficult to test in CI since it manifests when the library is pip-installed vs run from source. A test could verify that
_get_data_path()returns a writable directory.Any other comments?
This fix ensures the library works correctly whether installed via pip or run from a cloned repository.
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files