[ENH] Reformer forecaster added in ptf-v2#2089
Open
lucifer4073 wants to merge 4 commits intosktime:mainfrom
Open
[ENH] Reformer forecaster added in ptf-v2#2089lucifer4073 wants to merge 4 commits intosktime:mainfrom
lucifer4073 wants to merge 4 commits intosktime:mainfrom
Conversation
fkiraly
requested changes
Feb 24, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Thanks!
There is an incorrect import, please fix
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2089 +/- ##
=======================================
Coverage ? 86.31%
=======================================
Files ? 174
Lines ? 10119
Branches ? 0
=======================================
Hits ? 8734
Misses ? 1385
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lucifer4073
commented
Feb 27, 2026
Contributor
Author
lucifer4073
left a comment
There was a problem hiding this comment.
I have resolved the import related issues.
Thanks.
Contributor
Author
|
Could you please look into this ? It's been a week since I have updated the PR and all tests are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #2071.
What does this implement/fix? Explain your changes.
Integrates the Reformer forecaster into ptf-v2.
What should a reviewer concentrate their feedback on?
Check if the implementation technique is correct. There are 2 forecasting options
long_term_forecast(default) andshort_term_forecast.Did you add any tests for the change?
Appropriate test parameters were added in
reformer_pkg_v2.PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files