Skip to content

[MNT] Improve error message for invalid reduction argument in groupby_apply #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phoeenniixx merged 2 commits into from
Mar 4, 2026
Merged

[MNT] Improve error message for invalid reduction argument in groupby_apply #2104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c25f65c
Improve error message for invalid reduction argument in groupby_apply
Gyanam1310 Feb 27, 2026
edea7ee
Merge branch 'main' into improve-groupby-apply-error-message
phoeenniixx Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pytorch_forecasting/utils/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ def groupby_apply(
elif reduction == "sum":
reduce = torch.sum
else:
raise ValueError(f"Unknown reduction '{reduction}'")
raise ValueError(
f"Unknown reduction '{reduction}'. Expected one of {{'mean', 'sum'}}."
)
uniques, counts = keys.unique(return_counts=True)
groups = torch.stack(
[reduce(item) for item in torch.split_with_sizes(values, tuple(counts))]
Expand Down
Loading