Fix empty results when calling predict() twice#2123
Open
Koolvansh07 wants to merge 1 commit intosktime:mainfrom
Open
Fix empty results when calling predict() twice#2123Koolvansh07 wants to merge 1 commit intosktime:mainfrom
Koolvansh07 wants to merge 1 commit intosktime:mainfrom
Conversation
Koolvansh07
requested review from
PranavBhatP,
benHeid,
fkiraly,
fnhirwa,
jdb78,
phoeenniixx and
yarnabrina
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2123 +/- ##
=======================================
Coverage ? 86.63%
=======================================
Files ? 165
Lines ? 9733
Branches ? 0
=======================================
Hits ? 8432
Misses ? 1301
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where a second call to BaseModel.predict() can return an empty result.
The issue happens because predict() returned the local PredictCallback instance, while Lightning may attach/use a callback instance from rainer.callbacks after trainer/model attachment.
This patch returns the active PredictCallback from rainer.callbacks (falling back to the local one).
Tests
Closes #2108