Skip to content

fix: return predictions on multiple predict calls #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pankajbaid567 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: return predictions on multiple predict calls #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
419dae2
fix: return predictions on multiple predict calls
pankajbaid567 Mar 2, 2026
448140a
style: run pre-commit to fix formatting
pankajbaid567 Mar 2, 2026
7913927
chore: remove temporary test script
pankajbaid567 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/source/tutorials/stallion.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"source": [
"import warnings\n",
"\n",
"\n",
"warnings.filterwarnings(\"ignore\") # avoid printing out absolute paths"
]
},
Expand Down
10 changes: 9 additions & 1 deletion pytorch_forecasting/models/base/_base_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1755,7 +1755,15 @@ def predict(
logging.getLogger("lightning").setLevel(log_level_lighting)
logging.getLogger("pytorch_lightning").setLevel(log_level_pytorch_lightning)

return predict_callback.result
trainer_predict_callback = next(
(
callback
for callback in reversed(trainer.callbacks)
if isinstance(callback, PredictCallback)
),
predict_callback,
)
return trainer_predict_callback.result

def predict_dependency(
self,
Expand Down
13 changes: 13 additions & 0 deletions tests/test_models/test_temporal_fusion_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,19 @@ def test_prediction_with_dataloder(model, dataloaders_with_covariates, kwargs):
model.predict(val_dataloader, fast_dev_run=True, **kwargs)


def test_prediction_with_dataloader_twice(model, dataloaders_with_covariates):
val_dataloader = dataloaders_with_covariates["val"]
first_prediction = model.predict(
val_dataloader, fast_dev_run=True, return_index=True
)
second_prediction = model.predict(
val_dataloader, fast_dev_run=True, return_index=True
)

assert len(first_prediction.index) > 0
assert len(second_prediction.index) > 0


def test_prediction_with_dataloder_raw(data_with_covariates, tmp_path):
# tests correct concatenation of raw output
test_data = data_with_covariates.copy()
Expand Down
Loading