[ENH] Added TimeMoE forecaster to ptf-v2#2143
[ENH] Added TimeMoE forecaster to ptf-v2#2143lucifer4073 wants to merge 2 commits intosktime:mainfrom
TimeMoE forecaster to ptf-v2#2143Conversation
|
@lucifer4073 are you sure about interfacing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2143 +/- ##
=======================================
Coverage ? 86.67%
=======================================
Files ? 168
Lines ? 9817
Branches ? 0
=======================================
Hits ? 8509
Misses ? 1308
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@PranavBhatP Thanks for the comment. I was under the impression that all models in the THUML Time-Series module inherit from |
Yes, you are right, but the "models" here are only trainable encoder decoder models, not pre-trained models with imported weights. There are already some models like |
|
Also just another comment, try sticking to a smaller number of PRs. It would help you prioritize efforts on quality. The emphasis is on Quality > Quantity. I see almost 4 active model interface PRs from your end, but the effort is appreciated. This is just an advice from my end :) |
Reference Issues/PRs
Closes #2137.
What does this implement/fix? Explain your changes.
Implementation adds the
TimeMoEmodel in ptf-v2 inheritingTSLibBaseModel. Most of the implementation is similar to that in Thuml Time series library, except the following changestrainingargument which if set to false freezes the model backbone and uses.generate()method for zero-shot-inference. Defaults to True and passes data directly to backbone.logitsto getfuture_flat.What should a reviewer concentrate their feedback on?
Implementation adds
transformerdependency to ptf-v2.Did you add any tests for the change?
pkgfile consists of all the test args.Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files