[BUG] Fix in-place mutation in make_strings_unique#553
Open
SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
Open
[BUG] Fix in-place mutation in make_strings_unique#553SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551
The function
make_strings_uniquewas mutating the input list in-place due to a direct reference assignment. This PR ensures a copy is created before modification.Verified with a reproduction script: