Skip to content

[ENH] Gompertz distribution#1043

Open
smilingprogrammer wants to merge 2 commits intosktime:mainfrom
smilingprogrammer:fix-issue984
Open

[ENH] Gompertz distribution#1043
smilingprogrammer wants to merge 2 commits intosktime:mainfrom
smilingprogrammer:fix-issue984

Conversation

@smilingprogrammer
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #984

What does this implement/fix? Explain your changes.

This PR adds a new Gompertz probability distribution to skpro.
The implementation follows the existing SciPy-backed distribution pattern already used in the repository and adds:

  • a new Gompertz distribution class in skpro.distributions
  • namespace export in skpro/distributions/__init__.py

Does your contribution introduce a new dependency? If yes, which one?

No.

What should a reviewer concentrate their feedback on?

  • API consistency with existing SciPy-backed distributions
  • whether c and scale are the preferred public parameter names for this distribution
  • whether a dedicated estimator-specific test file should be added in this PR or in a follow-up

Did you add any tests for the change?

No. If preferred, I can add dedicated tests in a follow-up update.

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly fkiraly changed the title [ENH] Add Gompertz distribution [ENH] Gompertz distribution May 4, 2026
@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators interfacing algorithms Interfacing existing algorithms/estimators from third party packages labels May 4, 2026
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:probability&simulation probability distributions and simulators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Gompertz distribution

2 participants