[BUG] Add pytest.mark.asyncio decorator to fix async test failure (#41) - #51
Merged
Shashankss1205 merged 1 commit intoApr 4, 2026
Merged
Conversation
Contributor
Author
|
Greetings @Shashankss1205, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #41
What does this implement/fix? Explain your changes.
The
test_async_fit_predictfunction intests/test_background_jobs.pyis an async function but was missing the explicit@pytest.mark.asynciodecorator. Althoughpytest-asynciois in our dev dependencies andasyncio_mode = "auto"is set inpyproject.toml, adding the decorator explicitly ensures pytest correctly identifies and runs the async test without solely relying on auto mode.Changes:
import pytest.@pytest.mark.asynciodecorator totest_async_fit_predict.Does your contribution introduce a new dependency? If yes, which one?
No.
pytest-asynciois already listed in the dev dependencies.What should a reviewer concentrate their feedback on?
Nothing specific, just a one-line missing decorator.
Any other comments?
N/A
PR checklist
For all contributions
For new estimators