Skip to content

Conversation

@KaushikOP
Copy link

@KaushikOP KaushikOP commented Dec 23, 2025

This PR contains changes as follows:

  • Enabling power arch image builds for v2
  • Enabling plano tool for all image builds
  • Added new github action workflow files for frontend and backend
  • updated python version in Containerfiles as tag alpine uses updated python v3.14

I'm verifying Skupper on Power for MULTIARCH-5587

Details of successful validations of workflow files with custom images built -

  1. main

  2. backend

  3. frontend

CC: @prb112, @mjturek & @hash-d

Comment on lines +28 to +29
run(f"podman manifest rm {image_tag}", check=False)
run(f"podman rmi {image_tag}", check=False)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is only needed true outside of a workflow.

Comment on lines +29 to +30
run(f"podman manifest rm {image_tag}", check=False)
run(f"podman rmi {image_tag}", check=False)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as earlier... This addition is only needed true outside of a workflow.

run(f"podman build {no_cache_arg} --format docker -t {image_tag} .")
run(f"podman manifest rm {image_tag}", check=False)
run(f"podman rmi {image_tag}", check=False)
run(f"podman build {no_cache_arg} --format docker --platform linux/amd64,linux/arm64,linux/s390x,linux/ppc64le --file frontend/Containerfile --manifest {image_tag} ./frontend")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

run(f"podman build {no_cache_arg} --format docker -t {image_tag} .")
run(f"podman manifest rm {image_tag}", check=False)
run(f"podman rmi {image_tag}", check=False)
run(f"podman build {no_cache_arg} --format docker --platform linux/amd64,linux/arm64,linux/s390x,linux/ppc64le --file backend/Containerfile --manifest {image_tag} ./backend")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

USER fritz

COPY --from=build /usr/local/lib/python3.12/site-packages /usr/local/lib/python3.12/site-packages
COPY --from=build /usr/local/lib/python3.14/site-packages /usr/local/lib/python3.14/site-packages
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add a comment telling why inline.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a review comment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated python version in Containerfiles as tag alpine uses updated python v3.14

* Enabling plano tool for image builds
* Added new github action workflow files for frontend and backend
* updated python version in Containerfiles as tag alpine uses updated python v3.14

Signed-off-by: Kaushik Talathi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants