network observer operator script#2156
Conversation
| readonly OAUTH_PROXY_IMAGE_TAG=${OAUTH_PROXY_IMAGE_TAG:-4.18.0} | ||
| readonly NGINX_IMAGE_TAG=${NGINX_IMAGE_TAG:-1.27.3-alpine} | ||
|
|
||
| readonly IMG=${SKUPPER_IMAGE_REGISTRY}/network-observer-operator:v${SKUPPER_IMAGE_TAG} |
There was a problem hiding this comment.
Noticed that with the make target I ended up with network-observer-operator:vv2-dev here.
There was a problem hiding this comment.
Will distinguish skupper images from operator semver
fgiorgetti
left a comment
fgiorgetti
left a comment
There was a problem hiding this comment.
Another observation. How does the "replaces" attribute gets populated in case
of newer versions of the operator?
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| readonly SKUPPER_IMAGE_TAG=${1-2.0.1} |
There was a problem hiding this comment.
Fixed and added replaces to csv
| make docker-build docker-push IMG=${IMG} | ||
| make bundle-build bundle-push BUNDLE_IMG=${BUNDLE_IMG} |
There was a problem hiding this comment.
One thing I have noticed is that the produced images do not seem to be multiarch.
There was a problem hiding this comment.
includes multiarch builds now
fgiorgetti
left a comment
fgiorgetti
left a comment
There was a problem hiding this comment.
Minor suggestion, but it LGTM.
| readonly BUNDLE_DEFAULT_CHANNEL=${BUNDLE_DEFAULT_CHANNEL:-stable-2} | ||
|
|
||
| readonly REPLACED_VERSION=network-observer-operator.v${PREVIOUS_BUNDLE_VERSION} | ||
| readonly OLM_SKIP_RANGE='">2.0.0 <2.0.1"' |
c-kruse
left a comment
c-kruse
left a comment
There was a problem hiding this comment.
Very likely PEBKAC here, but I noticed several issues getting this running on openshift.
To install this I ended up running something like this:
make generate-network-observer-operator-bundle DEBUG=true SKUPPER_IMAGE_REGISTRY=<my-registry>- cd to the temp directory (left from DEBUG=true)
make deploy
Openshift/CRC
- the operator deployment wouldn't get scheduled because openshift didn't like the deployment spec had a userId: 1001.
- Deployment referenced just a "controller:latest" image?
|
Should cmd/network-observer/README.md be updated with instructions on how to use this script? |
5 participants
No description provided.