Skip to content

If cluster doesn't exist return an error message.#2167

Merged
nluaces merged 1 commit intoskupperproject:mainfrom
lynnemorrison:v2_no_version
Jun 27, 2025
Merged

If cluster doesn't exist return an error message.#2167
nluaces merged 1 commit intoskupperproject:mainfrom
lynnemorrison:v2_no_version

Conversation

@lynnemorrison
Copy link
Collaborator

Prints and error message instead of just printing headers with no data.

 fixes issue #2047

@lynnemorrison lynnemorrison force-pushed the v2_no_version branch 2 times, most recently from e246d4e to 41d492c Compare June 24, 2025 15:42
@lynnemorrison lynnemorrison requested a review from nluaces June 24, 2025 16:52
@nluaces
Copy link
Member

nluaces commented Jun 25, 2025

It shouldn't show an error, it should show the version of the images that we have by default.

@lynnemorrison
Copy link
Collaborator Author

lynnemorrison commented Jun 25, 2025

@nluaces from Issue #2047 it says:

"1. if the intention is to show the running versions, an error message should be shown stating that the operation cannot be completed, as the cluster is not accessible.
2. for baked-in images and environment variables, the command should return its information, in full, as it does not depend on the cluster."

So that is why I changed to an error message. I will change to just showing the default instead if that is the better solution.

@nluaces
Copy link
Member

nluaces commented Jun 25, 2025

@lynnemorrison the current version command is showing default images if skupper does not find a running container to which retrieve its version.

These images are being shown as the recommended versions that work with the skupper CLI version (examples: network-observer and its dependencies).

With other platforms that does not require a cluster like podman, the version command shows the default version (if I remember correctly).

In the meantime, I suggest to show the default versions if there is no cluster running for kubernetes environments.

How to show what type of version is an issue that still needs definition #2019

and should be done in a different pull request.

@lynnemorrison
Copy link
Collaborator Author

@nluaces Thanks for the clarification, will do!!

@lynnemorrison lynnemorrison force-pushed the v2_no_version branch 2 times, most recently from 893ae0d to f9595b0 Compare June 25, 2025 18:48
@nluaces nluaces merged commit 7356653 into skupperproject:main Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants